Skip to content

Update PySMS to use constants and add PySMS3 instructions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abao168899 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update PySMS to use constants and add PySMS3 instructions #5

abao168899 wants to merge 2 commits into from

Conversation

@abao168899
Copy link

@abao168899 abao168899 commented Feb 15, 2025 •
edited
Loading

Update PySMS.py, README.md, and PySMS3.py to improve functionality and documentation.

  • PySMS.py

    • Remove the carriers dictionary and import the CARRIERS dictionary from constants.py.
    • Update the add_number method to use the CARRIERS dictionary from constants.py.

  • README.md

    • Add instructions for using the PySMS3 class for sending SMS via email using Python 3.

  • PySMS3.py

    • Add error handling for the init_smtp method.
    • Add a method for sending text messages with a callback function.

For more details, open the Copilot Workspace session.

@abao168899
Update PySMS to use constants and add PySMS3 instructions
ce0045a 
Update `PySMS.py`, `README.md`, and `PySMS3.py` to improve functionality and documentation.

* **PySMS.py**
  - Remove the `carriers` dictionary and import the `CARRIERS` dictionary from `constants.py`.
  - Update the `add_number` method to use the `CARRIERS` dictionary from `constants.py`.

* **README.md**
  - Add instructions for using the `PySMS3` class for sending SMS via email using Python 3.

* **PySMS3.py**
  - Add error handling for the `init_smtp` method.
  - Add a method for sending text messages with a callback function.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/clayshieh/PySMS?shareId=XXXX-XXXX-XXXX-XXXX).
@abao168899
Update README.md to include instructions for sending text messages …
c456470 
…with a callback function

* Add example code for sending a text message with a callback function
* Add a callback function example that prints the message sent to the address
@abao168899
Copy link
Author

abao168899 commented Feb 15, 2025

This pull request includes several changes to the PySMS and PySMS3 modules, as well as updates to the README.md file. The changes enhance the functionality of the modules and improve error handling. Below are the most important changes:

PySMS Module Enhancements:

  • Refactored carrier definitions by moving them to a new constants module, improving code organization. [1] [2]
  • Added import statement for the new constants module.

PySMS3 Module Enhancements:

  • Improved error handling in the init_smtp method by adding a try-except block to catch smtplib.SMTPException errors.
  • Added a new method send_text_message_with_callback to send text messages with a callback function, enhancing functionality.
  • Updated imports to include Callable from the typing module.

Documentation Updates:

  • Added a new section to the README.md file with instructions for using the PySMS3 class for sending SMS via email using Python 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abao168899